Fix inline parameters lifted for 0 to 1 #4777
Merged
+50
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory the inline parameters are available in level 1, but we can access it "unlifted" as a value in level 0. To only pass the parameter once it is passed as a value and lifted using the standard lifter for the values. Unsing lifter is just an implementation detail and should not be observable by the user. The issue was that the lifter used could be replaced or unimported which yield unexpected error messages.
|
I originally implemented it with the implicit search thinking it would simplify the implementation logic. Clearly not the case. |
liufengyun
approved these changes
Jul 9, 2018
|
|
||
| val lifter = | ||
| if (tpSym eq defn.BooleanClass) defn.QuotedLiftable_BooleanIsLiftable | ||
| else if (tpSym eq defn.ByteClass) defn.QuotedLiftable_ByteLiftable |
There was a problem hiding this comment.
Nitpick: the name ByteLiftable is not consistent with other names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory the inline parameters are available in level 1,
but we can access it "unlifted" as a value in level 0.
To only pass the parameter once it is passed as a value and lifted
using the standard lifter for the values.
Unsing lifter is just an implementation detail and should not be observable
by the user. The issue was that the lifter used could be replaced or unimported
which yield unexpected error messages.